gokceni commented on a change in pull request #614: PHOENIX-5553: Transactional
views should not get GlobalIndexChecker c…
URL: https://github.com/apache/phoenix/pull/614#discussion_r340781671
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -927,7 +928,16 @@ private void addCoprocessors(byte[] tableName,
TableDescriptorBuilder builder, P
boolean isViewIndex = TRUE_BYTES_AS_STRING
.equals(tableProps.get(MetaDataUtil.IS_VIEW_INDEX_TABLE_PROP_NAME));
- if ((tableType == PTableType.INDEX && !isTransactional) ||
isViewIndex) {
+ boolean isViewBaseTransactional = false;
+ if (!isTransactional && isViewIndex) {
+ if (tableProps.containsKey(TRANSACTIONAL) &&
+ Boolean.TRUE.equals(tableProps.get(TRANSACTIONAL))) {
+ isViewBaseTransactional = true;
Review comment:
@BinShi-SecularBird I know it is weird but transactionProvider is null for
view. Transactional=true is set. If I use IsTransactional to check both
properties, that will regress some other logic in this function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
