[ 
https://issues.apache.org/jira/browse/PHOENIX-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967071#comment-16967071
 ] 

Lars Hofhansl commented on PHOENIX-3547:
----------------------------------------

Thanks [~m2je]! (my previous comment now reads a bit more grumpy than intended).

We're trying to get a 4.15.0 release out. When looking at the issues I found 
that fixing them is pretty .. tedious. There are many tricky details especially 
with local indexes, and I'm a bit worried that we'll miss more. I guess to 
start we should add tests for short viewIndexIds that cover the scenarios in 
the above four Jiras.

I'm happy to help as I have time (I'm working on some other things right now), 
towards the mid of the week we'll other have some other resources available at 
Salesforce.

It is also OK, IMHO, to revert now, and then reconsider for 4.16.0.

> Promote CATALOG.VIEW_INDEX_ID to an int
> ---------------------------------------
>
>                 Key: PHOENIX-3547
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3547
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: Jeremy Huffman
>            Assignee: Mehdi Salarkia
>            Priority: Blocker
>             Fix For: 4.15.0, 5.1.0
>
>         Attachments: 4.x-HBase-0.98.patch, 4.x-HBase-1.1.patch, 
> 4.x-HBase-1.2.patch, 4.x-HBase-1.3.patch, 4.x-HBase-1.4.patch, 
> 4.x-cdh5.11.patch, 4.x-cdh5.12.patch, 4.x-cdh5.13.patch, 4.x-cdh5.14.patch, 
> master-PHOENIX-3547.patch
>
>
> Increase the size of CATALOG.VIEW_INDEX_ID from smallint to int to support a 
> large number of indexed views on a single table.
> Per James: "The code would just need to be tolerant when reading the data if 
> the length is two byte short versus four byte int. At write time, we'd just 
> always write an int."
> See: 
> https://lists.apache.org/thread.html/22849e4fc73452cee3bea763cf6d5af7164dedcb44573ba6b9f452a2@%3Cuser.phoenix.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to