gjacoby126 commented on a change in pull request #607: PHOENIX-5103: Can't
create/drop table using 4.14 client against 4.15 server (Addendum)
URL: https://github.com/apache/phoenix/pull/607#discussion_r343243409
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
##########
@@ -1714,9 +1716,14 @@ public void createTable(RpcController controller,
CreateTableRequest request,
}
// check if the table was dropped, but had child views that were
have not yet been cleaned up
- if
(!Bytes.toString(schemaName).equals(QueryConstants.SYSTEM_SCHEMA_NAME) &&
- clientVersion >= MIN_SPLITTABLE_SYSTEM_CATALOG) {
- ViewUtil.dropChildViews(env, tenantIdBytes, schemaName,
tableName);
+ if
(!Bytes.toString(schemaName).equals(QueryConstants.SYSTEM_SCHEMA_NAME)) {
+ byte[] sysCatOrSysChildLink = SchemaUtil.getPhysicalTableName(
+ clientVersion >= MIN_SPLITTABLE_SYSTEM_CATALOG ?
Review comment:
nit: this would be much easier to read if you extracted the clientVersion ->
table byte logic into its own method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
