[ 
https://issues.apache.org/jira/browse/PHOENIX-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969704#comment-16969704
 ] 

Lars Hofhansl edited comment on PHOENIX-5559 at 11/8/19 6:30 AM:
-----------------------------------------------------------------

Perhaps someone else can have a look too, I'm having a lot of other things on 
my plate.

It fails in to detect the stale boundaries 
BaseScannerRegionObserver.throwIfScanOutOfRegion.

When we start index ids with Long.MIN_VALUE the scan start row is:

[0, 0, 0, 0, 0, 0, 0, 0, 102, 0, 117, 0, -128, 0, 0, 20, -128, 0, 0, 21, 0]

With Short.MIN_VALUE it's:
 [127, -1, -1, -1, -1, -1, -128, 0, 102, 0, 117, 0, -128, 0, 0, 20, -128, 0, 0, 
21, 0]

The region start keys are 'a'-'z', and so [127, ...] happens to fall into the 
very last region of the table. Looks like perhaps the stale region check does 
not work for the last region (both the scan and that region have the [] as stop 
row/key)? *I think that's another bug with local indexes.*

[~rajeshbabu], mind having a look. Just apply this patch and run 
MutableIndexSplitForwardScanIT and you'll see the (new) problem.

 


was (Author: lhofhansl):
Perhaps someone else can have a look too, I'm having a lot of other things on 
my plate.

It fails in to detect the stale boundaries 
BaseScannerRegionObserver.throwIfScanOutOfRegion.

When we start index ids with Long.MIN_VALUE the scan start row is:

[0, 0, 0, 0, 0, 0, 0, 0, 102, 0, 117, 0, -128, 0, 0, 20, -128, 0, 0, 21, 0]

With Short.MIN_VALUE it's:
 [127, -1, -1, -1, -1, -1, -128, 0, 102, 0, 117, 0, -128, 0, 0, 20, -128, 0, 0, 
21, 0]

The region start keys are 'a'-'z', and so [127, ...] happens to fall into the 
very last region of the table. Looks like perhaps the stale region check does 
not work for the last region (both the scan and that region have the [] as stop 
row/key)? *I think that's another bug with local indexes.*

[~rajeshbabu].

 

> With short index ids, index updates are written with the same index id in 
> 4.15.0
> --------------------------------------------------------------------------------
>
>                 Key: PHOENIX-5559
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5559
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.15.0, 5.1.0
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Blocker
>             Fix For: 4.15.0, 5.1.0
>
>         Attachments: 5559-4.x-HBase-1.5.txt, 5559-4.x-HBase-1.5.txt, 
> 5559-test.txt
>
>
>  
> {code:java}
> phoenix: CREATE TABLE test (pk INTEGER PRIMARY KEY, v1 INTEGER, v2 integer);
> No rows affected (1.389 seconds)
> phoenix: create local index l1 on test(v1);
> 1 row affected (11.343 seconds)
> phoenix: create local index l2 on test(v1);
> 1 row affected (5.107 seconds)
> phoenix: UPSERT INTO test VALUES(2,2,2);
> 1 row affected (0.037 seconds)
> hbase: scan 'TEST'
> ROW                                     COLUMN+CELL                           
>                                                                             
>  \x00\x00\xC1\x03\x00\x80\x00\x00\x02   column=L#0:\x00\x00\x00\x00, 
> timestamp=1572842063925, value=x                                              
>        
>  \x80\x00\x00\x02                       column=0:\x00\x00\x00\x00, 
> timestamp=1572842063925, value=x                                              
>          
>  \x80\x00\x00\x02                       column=0:\x80\x0B, 
> timestamp=1572842063925, value=\x80\x00\x00\x02                               
>                  
>  \x80\x00\x00\x02                       column=0:\x80\x0C, 
> timestamp=1572842063925, value=\x80\x00\x00\x02                               
>                  
> 2 row(s) in 0.0190 seconds{code}
> There should be two index rows.
> And in fact there are with phoenix.index.longViewIndex.enabled set to true, 
> there are correctly two different index entries for both of the local indexes.
> [~gjacoby] [~rajeshbabu]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to