[
https://issues.apache.org/jira/browse/PHOENIX-5508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970675#comment-16970675
]
Hadoop QA commented on PHOENIX-5508:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12985404/PHOENIX-5508-4.14-HBase-1.3.patch
against 4.14-HBase-1.3 branch at commit
70baf4c6805eb46420dd1fbaf71a093ab7d84a8b.
ATTACHMENT ID: 12985404
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ return new PostDDLMutationPlan(context, tableRefs, timestamp,
emptyCF, deleteList, projectCFs);
+ * 1) deletion of all rows for a DROP TABLE and subsequently
deletion of all rows for a DROP INDEX;
+ StatementContext context = new StatementContext(statement,
resolver, scan, new SequenceManager(statement));
+ // FIXME: DDL operations aren't transactional, so we're
basing the timestamp on a server timestamp.
+ // Not sure what the fix should be. We don't need conflict
detection nor filtering of invalid transactions
+
scan.setAttribute(BaseScannerRegionObserver.EMPTY_COLUMN_QUALIFIER,
EncodedColumnsUtil.getEmptyKeyValueInfo(tableRef.getTable()).getFirst());
+
scan.setAttribute(BaseScannerRegionObserver.DELETE_AGG, QueryConstants.TRUE);
+ // In the case of a row deletion, add index
metadata so mutable secondary indexing works
+ /* TODO: we currently manually run a scan to
delete the index data here
+ IndexMetaDataCacheClient client = new
IndexMetaDataCacheClient(connection, tableRef);
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexScrutinyToolIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.SaltedIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.NullIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3105//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3105//console
This message is automatically generated.
> ALTER INDEX REBUILD removes all rows from a simple global index
> ---------------------------------------------------------------
>
> Key: PHOENIX-5508
> URL: https://issues.apache.org/jira/browse/PHOENIX-5508
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Priority: Major
> Attachments: PHOENIX-5508-4.14-HBase-1.3.patch, PHOENIX-5508.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
