[ 
https://issues.apache.org/jira/browse/PHOENIX-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16971776#comment-16971776
 ] 

Chinmay Kulkarni commented on PHOENIX-5569:
-------------------------------------------

Copying over relevant parts from my dev-list email:
 # In our master branch, the maven-surefire plugin version is 
[2.22.2|https://github.com/apache/phoenix/blob/70baf4c6805eb46420dd1fbaf71a093ab7d84a8b/pom.xml#L126]
 and in our 4.x branches, it is 
[2.20|https://github.com/apache/phoenix/blob/69448a845e843628558e17032287fe9e2bb6c5cf/pom.xml#L127].
 Looks like PHOENIX-5459 was not applied to 4.x branches.
 # In some of our build hosts, we use the OpenJDK Runtime Environment (build 
11.0.4+11-post-Ubuntu-1ubuntu218.04.3), and in others we use Java(TM) SE 
Runtime Environment (build 1.8.0_191-b12). See 
[JDK-11-build|https://builds.apache.org/job/PreCommit-PHOENIX-Build/3091/consoleFull]
 vs 
[JDK-8-build|https://builds.apache.org/job/PreCommit-PHOENIX-Build/3100/consoleFull].
 
 # The "java.lang.NoClassDefFoundError: java/sql/SQLException: 
java.sql.SQLException" was a known issue (SUREFIRE-1265) for Java runtime 1.9+ 
and was fixed in version 2.20.1.
 # The builds that fail with the above error are only for 4.x branches + JDK 
11. Here are recent builds satisfying this combination (old surefire and new 
Java version) and failing with this error: 
[3095|https://builds.apache.org/job/PreCommit-PHOENIX-Build/3095/consoleFull], 
[3094|https://builds.apache.org/job/PreCommit-PHOENIX-Build/3094/consoleFull], 
[3093|https://builds.apache.org/job/PreCommit-PHOENIX-Build/3093/consoleFull], 
[3091|https://builds.apache.org/job/PreCommit-PHOENIX-Build/3091/consoleFull].
 # Builds on the master branch (surefire plugin 2.22.2) + JDK 11, do not fail 
with this error, for ex: 
[3089|https://builds.apache.org/job/PreCommit-PHOENIX-Build/3089/consoleFull], 
[3088|https://builds.apache.org/job/PreCommit-PHOENIX-Build/3088/consoleFull], 
[3092|https://builds.apache.org/job/PreCommit-PHOENIX-Build/3092/consoleFull] . 
Also, builds on 4.x branches (surefire plugin 2.20) + JDK 8 also do not fail 
with this error, for ex: 
[3100|https://builds.apache.org/job/PreCommit-PHOENIX-Build/3100/consoleFull], 
[3099|https://builds.apache.org/job/PreCommit-PHOENIX-Build/3099/consoleFull]

Backporting all of the JDK11 work is unnecessary at the moment and thus, there 
is no immediate need to backport PHOENIX-5459. Instead we can just bump up the 
surefire plugin version in the 4.x branches.

[~elserj] [~stoty]

> Bump up the maven surefire plugin version in 4.x branches to 2.22.2
> -------------------------------------------------------------------
>
>                 Key: PHOENIX-5569
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5569
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.15.0
>            Reporter: Chinmay Kulkarni
>            Assignee: Chinmay Kulkarni
>            Priority: Blocker
>             Fix For: 4.15.0
>
>
> Many recent builds on the 4.x branches are failing with:
>  
> {code:java}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on 
> project phoenix-core: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test failed: 
> java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException
> {code}
> due to an old surefire plugin version being used with JDK11. We need to bump 
> up the version to have reliable builds for the 4.x branches.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to