kadirozde commented on a change in pull request #625: PHOENIX-5565 Unify index
update structures in IndexRegionObserver and…
URL: https://github.com/apache/phoenix/pull/625#discussion_r344861799
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java
##########
@@ -616,20 +617,23 @@ public void
preBatchMutateWithExceptions(ObserverContext<RegionCoprocessorEnviro
setBatchMutateContext(c, context);
Mutation firstMutation = miniBatchOp.getOperation(0);
ReplayWrite replayWrite = this.builder.getReplayWrite(firstMutation);
+ context.rebuild = replayWrite != null;
/*
* Exclusively lock all rows so we get a consistent read
* while determining the index updates
*/
- if (replayWrite == null) {
+ long now;
+ if (!context.rebuild) {
populateRowsToLock(miniBatchOp, context);
lockRows(context);
- }
- long now = EnvironmentEdgeManager.currentTimeMillis();
- // Add the table rows in the mini batch to the collection of pending
rows. This will be used to detect
- // concurrent updates
- if (replayWrite == null) {
+ now = EnvironmentEdgeManager.currentTimeMillis();
+ // Add the table rows in the mini batch to the collection of pending
rows. This will be used to detect
+ // concurrent updates
populatePendingRows(context);
}
+ else {
+ now = EnvironmentEdgeManager.currentTimeMillis();
Review comment:
We cannot because we need to get the current time only after acquiring the
locks on the regular (non rebuild) code path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
