ChinmaySKulkarni commented on a change in pull request #628: PHOENIX-5546: 
TASK_TS being set as HConstants.LATEST_TIMESTAMP in SYSTEM.TASK table
URL: https://github.com/apache/phoenix/pull/628#discussion_r344990453
 
 

 ##########
 File path: 
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java
 ##########
 @@ -776,8 +771,14 @@ private long validateAndGetServerTimestamp(TableRef 
tableRef, MultiRowMutationSt
         // If we're auto committing, we've already validated the schema when 
we got the ColumnResolver,
         // so no need to do it again here.
         PTable table = tableRef.getTable();
-        MetaDataMutationResult result = 
client.updateCache(table.getSchemaName().getString(), table.getTableName()
-                .getString());
+
+        // We generally don't re-resolve SYSTEM tables, but if it relies on 
ROW_TIMESTAMP, we must
 
 Review comment:
   @twdsilva I think that makes sense. I will update the PR. Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to