yanxinyi commented on a change in pull request #616: PHOENIX-5432: Refactor
LiteralExpression to use the builder pattern
URL: https://github.com/apache/phoenix/pull/616#discussion_r345407780
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/compile/ProjectionCompiler.java
##########
@@ -103,7 +103,8 @@
* @since 0.1
*/
public class ProjectionCompiler {
- private static final Expression NULL_EXPRESSION =
LiteralExpression.newConstant(null);
+ private static Expression NULL_EXPRESSION = new
LiteralExpression.Builder().buildValueAndDeterminism(false);
Review comment:
why not `final` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
