gjacoby126 commented on a change in pull request #626: PHOENIX-5531:
IndexUpgradeTool crashes for tables without any indexes…
URL: https://github.com/apache/phoenix/pull/626#discussion_r345454267
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java
##########
@@ -333,6 +333,8 @@ private int executeTool(Connection conn,
ConnectionQueryServices queryServices,
LOGGER.info("Executing " + operation + " for " +
dataTableFullName);
boolean mutable = !(dataTable.isImmutableRows());
+ disableTable(admin, dataTableFullName, indexes);
+ modifyTable(admin, dataTableFullName, indexes);
if (!mutable) {
Review comment:
That would require having all tables in the batch be disabled at once,
right? So it's a tradeoff -- the process would be quicker, and the overall pain
less, but the pain that's there would be greater.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
