gjacoby126 commented on a change in pull request #625: PHOENIX-5565 Unify index
update structures in IndexRegionObserver and…
URL: https://github.com/apache/phoenix/pull/625#discussion_r345461062
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java
##########
@@ -149,16 +152,16 @@ public static void
setFailDataTableUpdatesForTesting(boolean fail) {
private final int clientVersion;
// The collection of index mutations that will be applied before the
data table mutations. The empty column (i.e.,
// the verified column) will have the value false ("unverified") on
these mutations
- private Collection<Pair<Mutation, byte[]>> preIndexUpdates =
Collections.emptyList();
+ private ListMultimap<HTableInterfaceReference, Mutation> preIndexUpdates;
Review comment:
Doesn't have to be this patch, but we should consider extracting this
ListMultimap<HTableInterfaceReference, Mutation> into a class of some kind with
named accessor methods so that code dealing with it can be at a higher level of
abstraction / more self-documenting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
