ChinmaySKulkarni commented on a change in pull request #629: PHOENIX-5559 Fix
remaining issues with Long viewIndexIds.
URL: https://github.com/apache/phoenix/pull/629#discussion_r345536817
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
##########
@@ -178,8 +178,11 @@ private static void throwIfScanOutOfRegion(Scan scan,
Region region) throws DoNo
byte[] expectedUpperRegionKey =
scan.getAttribute(EXPECTED_UPPER_REGION_KEY) == null ?
scan.getStopRow() : scan
.getAttribute(EXPECTED_UPPER_REGION_KEY);
- isStaleRegionBoundaries = expectedUpperRegionKey != null &&
- Bytes.compareTo(upperExclusiveRegionKey,
expectedUpperRegionKey) != 0;
+
Review comment:
@lhofhansl I think that makes sense given what's happening when you get a
[StaleRegionBoundaryCacheException](https://github.com/apache/phoenix/blob/f8cfa6b8b9f63ab080cdafa486bb4aabf043b1f8/phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java#L1315)
and call
BaseResultIterators#[recreateIterators](https://github.com/apache/phoenix/blob/f8cfa6b8b9f63ab080cdafa486bb4aabf043b1f8/phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java#L1405)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
