[
https://issues.apache.org/jira/browse/PHOENIX-5566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973069#comment-16973069
]
Hadoop QA commented on PHOENIX-5566:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12985676/PHOENIX-5566_v1-4.x-HBase-1.4.patch
against 4.x-HBase-1.4 branch at commit
f8cfa6b8b9f63ab080cdafa486bb4aabf043b1f8.
ATTACHMENT ID: 12985676
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 13 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ public ValueGetterWithTimestampTracker
getIndexUpdateState(Collection<? extends ColumnReference> indexedColumns,
boolean ignoreNewerMutations, boolean returnNullScannerIfRowNotFound,
IndexMetaData indexMetaData)
+ final ColumnsMinTimestampTracker tracker = new
ColumnsMinTimestampTracker(indexedColumns);
+ public ValueGetterWithTimestampTracker getIndexUpdateState(Collection<?
extends ColumnReference> indexedColumns, boolean ignoreNewerMutations, boolean
isStateForDeletes, IndexMetaData indexMetaData)
+ CoveredDeleteScanner scanner =
getIndexedColumnsTableState(indexedColumns, ignoreNewerMutations,
isStateForDeletes, indexMetaData);
+ private void addMutationsForBatch(IndexUpdateManager updateMap, Batch
batch, LocalTableState state,
+ private void addCurrentStateMutationsForBatch(IndexUpdateManager
updateMap, LocalTableState state, IndexMetaData indexMetaData)
+ * If {@link #getLatestValue} encountered cells with newer timestamps
than the timestamp of the
+ * @param ignoreNewerMutations ignore mutations newer than m when
determining current state. Useful
+ * when replaying mutation state for partial index rebuild where
writes succeeded to the data
+ Collection<? extends ColumnReference> indexedColumns, boolean
ignoreNewerMutations, boolean returnNullScannerIfRowNotFound, IndexMetaData
indexMetaData) throws IOException;
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3120//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3120//console
This message is automatically generated.
> Remove useless LocalTableState.trackedColumns
> ----------------------------------------------
>
> Key: PHOENIX-5566
> URL: https://issues.apache.org/jira/browse/PHOENIX-5566
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.15.0, 5.1.0
> Reporter: chenglei
> Assignee: chenglei
> Priority: Major
> Fix For: 4.15.1, 5.1.1
>
> Attachments: PHOENIX-5566_v1-4.x-HBase-1.4.patch
>
>
> I found that LocalTableState.trackedColumns is useless now, so we can remove
> it and make the index building code more readable. IMHO, the index building
> code is hard to understand
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
