[
https://issues.apache.org/jira/browse/PHOENIX-5494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973696#comment-16973696
]
Hadoop QA commented on PHOENIX-5494:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12985776/PHOENIX-5494.master.001.patch
against master branch at commit 910b72bf5d3b51a0c30ce43d9b19c0ce089cda62.
ATTACHMENT ID: 12985776
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ public void scanCurrentRowStates(Set<ImmutableBytesPtr> rows,
IndexMetaData indexMetaData, long ts) throws IOException {
+ List<IndexMaintainer> indexMaintainers =
((PhoenixIndexMetaData)indexMetaData).getIndexMaintainers();
+ columns.add(new
ColumnReference(indexMaintainers.get(0).getDataEmptyKeyValueCF(),
indexMaintainers.get(0).getEmptyKeyValueQualifier()));
+ public void scanCurrentRowStates(Set<ImmutableBytesPtr> rows, Collection<?
extends ColumnReference> columns, long ts)
+ public void scanCurrentRowStates(Set<ImmutableBytesPtr> rows, Collection<?
extends ColumnReference> columns, long ts) throws IOException {
+ public void scanCurrentRowStates(Set<ImmutableBytesPtr> rows, Collection<?
extends ColumnReference> columns, long ts)
+ public void scanCurrentRowStates(Set<ImmutableBytesPtr> rows, Collection<?
extends ColumnReference> columns, long ts) throws IOException {
+ filterList.addFilter(new RowFilter(CompareOperator.EQUAL, new
BinaryComparator(row.get())));
+ System.arraycopy(cell.getRowArray(), cell.getRowOffset(),
rowKey, 0, cell.getRowLength());
+ public void scanCurrentRowStates(Set<ImmutableBytesPtr> rows, Collection<?
extends ColumnReference> columns, long ts)
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3122//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3122//console
This message is automatically generated.
> Batched, mutable Index updates are unnecessarily run one-by-one
> ---------------------------------------------------------------
>
> Key: PHOENIX-5494
> URL: https://issues.apache.org/jira/browse/PHOENIX-5494
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Lars Hofhansl
> Assignee: Kadir OZDEMIR
> Priority: Major
> Labels: performance
> Attachments: PHOENIX-5494.master.001.patch,
> Screenshot_20191110_160243.png, Screenshot_20191110_160351.png,
> Screenshot_20191110_161453.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I just noticed that index updates on mutable tables retrieve their deletes
> (to invalidate the old index entry) one-by-one.
> For batches, this can be *the* major time spent during an index update. The
> cost is mostly incured by the repeated setup (and seeking) of the new region
> scanner (for each row).
> We can instead do a skip scan and get all updates in a single scan per region.
> (Logically that is simple, but it will require some refactoring)
> I won't be getting to this, but recording it here in case someone feels
> inclined.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
