gjacoby126 commented on a change in pull request #631: PHOENIX-5494 Batched,
mutable Index updates are unnecessarily run one…
URL: https://github.com/apache/phoenix/pull/631#discussion_r346002089
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/covered/data/LocalTable.java
##########
@@ -49,15 +61,53 @@
public class LocalTable implements LocalHBaseState {
private RegionCoprocessorEnvironment env;
+ private Map<ImmutableBytesPtr, Result> results = new HashMap<>();;
public LocalTable(RegionCoprocessorEnvironment env) {
this.env = env;
}
+ public void scanCurrentRowStates(Set<ImmutableBytesPtr> rows, Collection<?
extends ColumnReference> columns, long ts) throws IOException {
+ Scan s =
IndexManagementUtil.newLocalStateScan(Collections.singletonList(columns));
+ FilterList filterList = new
FilterList(FilterList.Operator.MUST_PASS_ONE);
+ for (ImmutableBytesPtr row : rows) {
Review comment:
just fyi, In the past we've found perf issues with FilterLists with enormous
numbers of filters (> 5000)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
