[
https://issues.apache.org/jira/browse/PHOENIX-5531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973808#comment-16973808
]
Hadoop QA commented on PHOENIX-5531:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12985788/PHOENIX-5531.4.x-HBase-1.3.patch
against 4.x-HBase-1.3 branch at commit
910b72bf5d3b51a0c30ce43d9b19c0ce089cda62.
ATTACHMENT ID: 12985788
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ HashMap<String, IndexInfo> rebuildMap =
prepareToRebuildIndexes(conn, dataTableFullName);
+ tenantId == null ? GLOBAL_INDEX_ID : tenantId,
viewIndex, viewIndexPhysicalName);
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3124//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3124//console
This message is automatically generated.
> IndexUpgradeTool crashes for tables without any indexes + Sleep problems
> ------------------------------------------------------------------------
>
> Key: PHOENIX-5531
> URL: https://issues.apache.org/jira/browse/PHOENIX-5531
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.15.0, 4.14.3
> Reporter: Priyank Porwal
> Assignee: Swaroopa Kadam
> Priority: Minor
> Fix For: 4.15.1, 4.14.3, 5.1.1
>
> Attachments: PHOENIX-5531.4.x-HBase-1.3.patch
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> INFO: No indexes to rebuild for table <TableWithoutIndexes>
> Exception in thread "main" java.lang.NullPointerException
> at
> org.apache.phoenix.mapreduce.index.IndexUpgradeTool.rebuildIndexes(IndexUpgradeTool.java:480)
> at
> org.apache.phoenix.mapreduce.index.IndexUpgradeTool.rebuildIndexes(IndexUpgradeTool.java:419)
> at
> org.apache.phoenix.mapreduce.index.IndexUpgradeTool.executeTool(IndexUpgradeTool.java:346)
> at
> org.apache.phoenix.mapreduce.index.IndexUpgradeTool.executeTool(IndexUpgradeTool.java:312)
> at
> org.apache.phoenix.mapreduce.index.IndexUpgradeTool.run(IndexUpgradeTool.java:175)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
> at
> org.apache.phoenix.mapreduce.index.IndexUpgradeTool.main(IndexUpgradeTool.java:673)
>
> Also, the tool sleeps for expiry of cached table info's on clients can even
> when run in dry-mode. Besides, the sleep seems to be at the wrong point -
> before any changes to table/index metadata. The sleep needs to be after the
> metadata changes are done.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
