jpisaac commented on a change in pull request #599: Create columns in SYSCAT
and fields in PTable.proto for view TTL support
URL: https://github.com/apache/phoenix/pull/599#discussion_r346924584
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
##########
@@ -2650,6 +2685,8 @@ else if
(!SchemaUtil.isSystemTable(Bytes.toBytes(SchemaUtil.getTableName(schemaN
.setIndexes(Collections.<PTable>emptyList())
.setPhysicalNames(ImmutableList.<PName>of())
.setColumns(columns.values())
+ .setViewTTL(0L)
Review comment:
My understanding is this is special handling for SYSTEM table as the comment
above says. We do not want to set TTL for any SYSTEM tables.
But your comment about extracting 0L as a special constant makes sense. I
will do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
