[
https://issues.apache.org/jira/browse/PHOENIX-5494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976355#comment-16976355
]
Hadoop QA commented on PHOENIX-5494:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12986087/PHOENIX-5494_v2-4.x-HBase-1.4.patch
against 4.x-HBase-1.4 branch at commit
234660ea0082815c59704a61dc9c33bb11d64381.
ATTACHMENT ID: 12986087
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 14 new
or modified tests.
{color:red}-1 javac{color}. The patch appears to cause mvn compile goal to
fail .
Compilation errors resume:
[ERROR] COMPILATION ERROR :
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/test/java/org/apache/phoenix/hbase/index/covered/NonTxIndexBuilderTest.java:[217,62]
method preScanAllRequiredRows in class
org.apache.phoenix.hbase.index.builder.IndexBuildManager cannot be applied to
given types;
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/test/java/org/apache/phoenix/hbase/index/covered/NonTxIndexBuilderTest.java:[268,62]
method preScanAllRequiredRows in class
org.apache.phoenix.hbase.index.builder.IndexBuildManager cannot be applied to
given types;
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/test/java/org/apache/phoenix/hbase/index/covered/NonTxIndexBuilderTest.java:[310,62]
method preScanAllRequiredRows in class
org.apache.phoenix.hbase.index.builder.IndexBuildManager cannot be applied to
given types;
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.0:testCompile
(default-testCompile) on project phoenix-core: Compilation failure: Compilation
failure:
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/test/java/org/apache/phoenix/hbase/index/covered/NonTxIndexBuilderTest.java:[217,62]
method preScanAllRequiredRows in class
org.apache.phoenix.hbase.index.builder.IndexBuildManager cannot be applied to
given types;
[ERROR] required: java.util.Collection<? extends
org.apache.hadoop.hbase.client.Mutation>,org.apache.phoenix.index.PhoenixIndexMetaData,org.apache.hadoop.hbase.coprocessor.RegionCoprocessorEnvironment
[ERROR] found:
java.util.List<org.apache.phoenix.hbase.index.MultiMutation>,org.apache.phoenix.index.PhoenixIndexMetaData,int,org.apache.hadoop.hbase.coprocessor.RegionCoprocessorEnvironment
[ERROR] reason: actual and formal argument lists differ in length
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/test/java/org/apache/phoenix/hbase/index/covered/NonTxIndexBuilderTest.java:[268,62]
method preScanAllRequiredRows in class
org.apache.phoenix.hbase.index.builder.IndexBuildManager cannot be applied to
given types;
[ERROR] required: java.util.Collection<? extends
org.apache.hadoop.hbase.client.Mutation>,org.apache.phoenix.index.PhoenixIndexMetaData,org.apache.hadoop.hbase.coprocessor.RegionCoprocessorEnvironment
[ERROR] found: java.util.Collection<capture#1 of ? extends
org.apache.hadoop.hbase.client.Mutation>,org.apache.phoenix.index.PhoenixIndexMetaData,int,org.apache.hadoop.hbase.coprocessor.RegionCoprocessorEnvironment
[ERROR] reason: actual and formal argument lists differ in length
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/src/test/java/org/apache/phoenix/hbase/index/covered/NonTxIndexBuilderTest.java:[310,62]
method preScanAllRequiredRows in class
org.apache.phoenix.hbase.index.builder.IndexBuildManager cannot be applied to
given types;
[ERROR] required: java.util.Collection<? extends
org.apache.hadoop.hbase.client.Mutation>,org.apache.phoenix.index.PhoenixIndexMetaData,org.apache.hadoop.hbase.coprocessor.RegionCoprocessorEnvironment
[ERROR] found: java.util.Collection<capture#2 of ? extends
org.apache.hadoop.hbase.client.Mutation>,org.apache.phoenix.index.PhoenixIndexMetaData,int,org.apache.hadoop.hbase.coprocessor.RegionCoprocessorEnvironment
[ERROR] reason: actual and formal argument lists differ in length
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <args> -rf :phoenix-core
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3142//console
This message is automatically generated.
> Batched, mutable Index updates are unnecessarily run one-by-one
> ---------------------------------------------------------------
>
> Key: PHOENIX-5494
> URL: https://issues.apache.org/jira/browse/PHOENIX-5494
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Lars Hofhansl
> Assignee: Kadir OZDEMIR
> Priority: Major
> Labels: performance
> Attachments: 5494-4.x-HBase-1.5.txt,
> PHOENIX-5494-4.x-HBase-1.4.patch, PHOENIX-5494.master.001.patch,
> PHOENIX-5494.master.002.patch, PHOENIX-5494.master.003.patch,
> Screenshot_20191110_160243.png, Screenshot_20191110_160351.png,
> Screenshot_20191110_161453.png
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> I just noticed that index updates on mutable tables retrieve their deletes
> (to invalidate the old index entry) one-by-one.
> For batches, this can be *the* major time spent during an index update. The
> cost is mostly incured by the repeated setup (and seeking) of the new region
> scanner (for each row).
> We can instead do a skip scan and get all updates in a single scan per region.
> (Logically that is simple, but it will require some refactoring)
> I won't be getting to this, but recording it here in case someone feels
> inclined.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
