dbwong commented on issue #626: PHOENIX-5531: IndexUpgradeTool crashes for 
tables without any indexes…
URL: https://github.com/apache/phoenix/pull/626#issuecomment-555249611
 
 
   > Can we have a unit tests for these changes?
   
   I saw this was already merged without reply to my comment.  Can we consider 
more unit test for pieces of code that are easily unit testable?    
@priyankporwal @gjacoby126 @swaroopak The index tool is new code.  It should be 
built in a testable fashion.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to