christinefeng commented on a change in pull request #616: PHOENIX-5432:
Refactor LiteralExpression to use the builder pattern
URL: https://github.com/apache/phoenix/pull/616#discussion_r347674651
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/expression/LiteralExpression.java
##########
@@ -242,6 +296,9 @@ private LiteralExpression(Object value, PDataType type,
byte[] byteValue,
this.determinism = deterministic;
}
+ public LiteralExpression () {
Review comment:
I believe it's used in some of the test cases that access
LiteralExpression.init
At least, some of the unit tests were failing before I added the default
constructor
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
