[ 
https://issues.apache.org/jira/browse/PHOENIX-5494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980672#comment-16980672
 ] 

Hudson commented on PHOENIX-5494:
---------------------------------

SUCCESS: Integrated in Jenkins build Phoenix-4.x-HBase-1.5 #201 (See 
[https://builds.apache.org/job/Phoenix-4.x-HBase-1.5/201/])
PHOENIX-5494 Batched, mutable Index updates are unnecessarily run (chenglei: 
rev 0a2552ec7198dc7b7529a35e416340e4306c1a64)
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/covered/NonTxIndexBuilder.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/builder/IndexBuilder.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/builder/BaseIndexBuilder.java
* (delete) 
phoenix-core/src/test/java/org/apache/phoenix/hbase/index/covered/data/TestLocalTable.java
* (edit) 
phoenix-core/src/test/java/org/apache/phoenix/hbase/index/covered/TestCoveredColumnIndexCodec.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/builder/IndexBuildManager.java
* (edit) 
phoenix-core/src/test/java/org/apache/phoenix/hbase/index/covered/LocalTableStateTest.java
* (edit) 
phoenix-core/src/test/java/org/apache/phoenix/hbase/index/covered/NonTxIndexBuilderTest.java
* (add) 
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/covered/data/CachedLocalTable.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/covered/LocalTableState.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/util/IndexManagementUtil.java
* (delete) 
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/covered/data/LocalTable.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/hbase/index/covered/data/LocalHBaseState.java


> Batched, mutable Index updates are unnecessarily run one-by-one
> ---------------------------------------------------------------
>
>                 Key: PHOENIX-5494
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5494
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Lars Hofhansl
>            Assignee: chenglei
>            Priority: Major
>              Labels: performance
>         Attachments: 5494-4.x-HBase-1.5.txt, 
> PHOENIX-5494-4.x-HBase-1.4.patch, PHOENIX-5494.master.001.patch, 
> PHOENIX-5494.master.002.patch, PHOENIX-5494.master.003.patch, 
> PHOENIX-5494_v3-4.x-HBase-1.4.patch, PHOENIX-5494_v6-4.x-HBase-1.4.patch, 
> PHOENIX-5494_v7-4.x-HBase-1.4.patch, Screenshot_20191110_160243.png, 
> Screenshot_20191110_160351.png, Screenshot_20191110_161453.png
>
>          Time Spent: 5h 20m
>  Remaining Estimate: 0h
>
> I just noticed that index updates on mutable tables retrieve their deletes 
> (to invalidate the old index entry) one-by-one.
> For batches, this can be *the* major time spent during an index update. The 
> cost is mostly incured by the repeated setup (and seeking) of the new region 
> scanner (for each row).
> We can instead do a skip scan and get all updates in a single scan per region.
> (Logically that is simple, but it will require some refactoring)
> I won't be getting to this, but recording it here in case someone feels 
> inclined.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to