[
https://issues.apache.org/jira/browse/PHOENIX-5494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980996#comment-16980996
]
chenglei edited comment on PHOENIX-5494 at 11/24/19 8:10 AM:
-------------------------------------------------------------
[~larsh], seems that apply 4.x-HBase-1.4 patch to master failed the
{{MutableIndexFailureIT}}，such as:
[ERROR]
testIndexWriteFailure[MutableIndexFailureIT_transactionProvider=null,localIndex=false,isNamespaceMapped=false,disableIndexOnWriteFailure=false,failRebuildTask=false,throwIndexWriteFailure=false](org.apache.phoenix.end2end.index.MutableIndexFailureIT)
Time elapsed: 14.087 s <<< FAILURE!
org.junit.ComparisonFailure: expected:<x[2]> but was:<x[]>
at
org.apache.phoenix.end2end.index.MutableIndexFailureIT.validateDataWithIndex(MutableIndexFailureIT.java:506)
at
org.apache.phoenix.end2end.index.MutableIndexFailureIT.testIndexWriteFailure(MutableIndexFailureIT.java:369)
I have revert master and 4.x.
was (Author: comnetwork):
[~larsh], seems that apply 4.x-HBase-1.4 patch to master failed the
{{MutableIndexFailureIT}}，such as:
[ERROR]
testIndexWriteFailure[MutableIndexFailureIT_transactionProvider=null,localIndex=false,isNamespaceMapped=false,disableIndexOnWriteFailure=false,failRebuildTask=false,throwIndexWriteFailure=false](org.apache.phoenix.end2end.index.MutableIndexFailureIT)
Time elapsed: 14.087 s <<< FAILURE!
org.junit.ComparisonFailure: expected:<x[2]> but was:<x[]>
at
org.apache.phoenix.end2end.index.MutableIndexFailureIT.validateDataWithIndex(MutableIndexFailureIT.java:506)
at
org.apache.phoenix.end2end.index.MutableIndexFailureIT.testIndexWriteFailure(MutableIndexFailureIT.java:369)
> Batched, mutable Index updates are unnecessarily run one-by-one
> ---------------------------------------------------------------
>
> Key: PHOENIX-5494
> URL: https://issues.apache.org/jira/browse/PHOENIX-5494
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.15.0, 5.1.0
> Reporter: Lars Hofhansl
> Assignee: chenglei
> Priority: Major
> Labels: performance
> Fix For: 4.15.1, 5.1.1
>
> Attachments: 5494-4.x-HBase-1.5.txt,
> PHOENIX-5494-4.x-HBase-1.4.patch, PHOENIX-5494.master.001.patch,
> PHOENIX-5494.master.002.patch, PHOENIX-5494.master.003.patch,
> PHOENIX-5494_v3-4.x-HBase-1.4.patch, PHOENIX-5494_v6-4.x-HBase-1.4.patch,
> PHOENIX-5494_v7-4.x-HBase-1.4.patch, PHOENIX-5494_v8-master.patch,
> Screenshot_20191110_160243.png, Screenshot_20191110_160351.png,
> Screenshot_20191110_161453.png
>
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> I just noticed that index updates on mutable tables retrieve their deletes
> (to invalidate the old index entry) one-by-one.
> For batches, this can be *the* major time spent during an index update. The
> cost is mostly incured by the repeated setup (and seeking) of the new region
> scanner (for each row).
> We can instead do a skip scan and get all updates in a single scan per region.
> (Logically that is simple, but it will require some refactoring)
> I won't be getting to this, but recording it here in case someone feels
> inclined.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
