ChinmaySKulkarni commented on a change in pull request #616: PHOENIX-5432:
Refactor LiteralExpression to use the builder pattern
URL: https://github.com/apache/phoenix/pull/616#discussion_r350913773
##########
File path:
phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/DataTableLocalIndexRegionScanner.java
##########
@@ -91,15 +92,19 @@ public boolean next(List<Cell> outResult, ScannerContext
scannerContext) throws
public boolean next(List<Cell> results) throws IOException {
List<Cell> dataTableResults = new ArrayList<Cell>();
boolean next = super.next(dataTableResults);
- addMutations(dataTableResults);
+ try {
+ addMutations(dataTableResults);
+ } catch (SQLException e) {
+ e.printStackTrace();
Review comment:
We shouldn't ever be swallowing an exception and printing to stdout/stderr.
We should log it at worst. Any reason this exception shouldn't bubble up?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
