[
https://issues.apache.org/jira/browse/PHOENIX-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982935#comment-16982935
]
Hadoop QA commented on PHOENIX-5593:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12986835/PHOENIX-5593.master.000.patch
against master branch at commit cdabf29aa7440c4a8b8c85b81542121ffcb7baac.
ATTACHMENT ID: 12986835
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ParameterizedIndexUpgradeToolIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3156//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3156//console
This message is automatically generated.
> Remove null checks for JoinCompiler
> -----------------------------------
>
> Key: PHOENIX-5593
> URL: https://issues.apache.org/jira/browse/PHOENIX-5593
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.1.0, 4.14.4
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Minor
> Fix For: 4.15.0, 5.1.0, 4.14.4
>
> Attachments: PHOENIX-5593.master.000.patch
>
>
> JoinCompiler.getCommonType() has redundant null checks for PDataType that can
> be removed
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
