[
https://issues.apache.org/jira/browse/PHOENIX-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16983026#comment-16983026
]
Hadoop QA commented on PHOENIX-5589:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12986844/PHOENIX-5589.4.x-HBase-1.5.001.patch
against 4.x-HBase-1.5 branch at commit
cdabf29aa7440c4a8b8c85b81542121ffcb7baac.
ATTACHMENT ID: 12986844
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ // No need to run the same test twice one for async = true and
the other for async = false
+ "CONSTRAINT pk PRIMARY KEY (oid, kp))
COLUMN_ENCODED_BYTES=0, MULTI_TENANT=true");
+ "val2 varchar, val3 varchar, CONSTRAINT pk PRIMARY KEY
(id)) AS SELECT * FROM " + dataTableName +
+ // Configure IndexRegionObserver to fail the last write phase
(i.e., the post index update phase)
+ tenantConn.createStatement().execute("CREATE VIEW " +
childViewName + " (zid CHAR(15)) " +
+ tenantConn.createStatement().execute("CREATE VIEW " +
grandChildViewName + " (val4 CHAR(15)) " +
+ tenantConn.createStatement().execute("upsert into " +
childViewName + " (zid, id, val1, val2, val3) VALUES('z1','1',
'a1','b1','c1')");
+ // Configure IndexRegionObserver to fail the last write phase
(i.e., the post index update phase)
+ tenantConn.createStatement().execute("upsert into " +
grandChildViewName + " (zid, id, val4) VALUES('z1','1', 'd1')");
+ // MetaDataClient modifies the index table name for view indexes if
the parent view of an index has a child
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3157//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3157//console
This message is automatically generated.
> GlobalIndexChecker does not populate global index related attributes for
> certain queries
> ----------------------------------------------------------------------------------------
>
> Key: PHOENIX-5589
> URL: https://issues.apache.org/jira/browse/PHOENIX-5589
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.15.0
> Reporter: Jacob Isaac
> Assignee: Kadir OZDEMIR
> Priority: Blocker
> Fix For: 4.15.0, 5.1.0
>
> Attachments: PHOENIX-5589.4.x-HBase-1.5.001.patch,
> PHOENIX-5589.master.001.patch, PHOENIX-5589.master.002.patch
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> To reproduce:
> CREATE TABLE IF NOT EXISTS "TEST_ENTITY"."T_T000001"(OID CHAR(15) NOT NULL,KP
> CHAR(3) NOT NULL, COL1 VARCHAR,COL2 VARCHAR,COL3 VARCHAR CONSTRAINT pk
> PRIMARY KEY (OID,KP)) COLUMN_ENCODED_BYTES=0,
> MULTI_TENANT=true,DEFAULT_COLUMN_FAMILY='Z';
> CREATE VIEW IF NOT EXISTS "TEST_ENTITY"."V_T000001"(ID CHAR(15) NOT NULL,COL4
> VARCHAR,COL5 VARCHAR,COL6 VARCHAR CONSTRAINT pk PRIMARY KEY (ID)) AS SELECT *
> FROM "TEST_ENTITY"."T_T000001" WHERE KP = '0EC';
> CREATE INDEX IF NOT EXISTS IDX_V_T000001 ON "TEST_ENTITY"."V_T000001"(COL4)
> INCLUDE (COL6) ;
> CREATE VIEW IF NOT EXISTS "TEST_ENTITY"."0EC"(ZID CHAR(15),COL7 VARCHAR,COL8
> VARCHAR,COL9 VARCHAR) AS SELECT * FROM "TEST_ENTITY"."V_T000001";
> UPSERT INTO "TEST_ENTITY"."0EC" (ZID,ID,COL4,COL5,COL6)
> VALUES('z1','1','g1','h1','i1');
> UPSERT INTO "TEST_ENTITY"."0EC" (ZID,ID,COL4,COL5,COL6)
> VALUES('z2','2','g2','h2','i2');
> UPSERT INTO "TEST_ENTITY"."0EC" (ZID,ID,COL4,COL5,COL6)
> VALUES('z3','3','g3','h3','i3');
> UPSERT INTO "TEST_ENTITY"."0EC" (ZID,ID,COL4,COL5,COL6)
> VALUES('z4','4','g4','h4','i4');
> UPSERT INTO "TEST_ENTITY"."0EC" (ZID,ID,COL4,COL5,COL6)
> VALUES('z5','5','g5','h5','i5');
> When running the following queries (COL6 is the included col, COL4 is the
> indexed column)
> select COL6 from "TEST_ENTITY"."0EC" where COL4 = 'g3';
> The scan attributes are not properly set. (i.e for eg CHECK_VERIFY_COLUMN is
> not set)
> [~kadir]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
