[
https://issues.apache.org/jira/browse/PHOENIX-5593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16983867#comment-16983867
]
Chinmay Kulkarni edited comment on PHOENIX-5593 at 11/27/19 7:43 PM:
---------------------------------------------------------------------
[~vjasani] patch looks good, though one of the test failures looks like an NPE
(however, it doesn't look related to your changes). Just to be sure, can you
attach another patch (same content, different name, perhaps
<PHOENIX-5593-master-v1.patch>) to get another QA run?
was (Author: ckulkarni):
[~vjasani] patch looks good and one of the test failures looks like an NPE
(though it doesn't look related to your changes). Just to be sure, can you
attach another patch (same content, different name, perhaps
<PHOENIX-5593-master-v1.patch>) to get another QA run?
> Remove null checks for JoinCompiler
> -----------------------------------
>
> Key: PHOENIX-5593
> URL: https://issues.apache.org/jira/browse/PHOENIX-5593
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.15.0, 5.1.0, 4.14.4
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Minor
> Fix For: 5.1.0, 4.15.1
>
> Attachments: PHOENIX-5593.master.000.patch
>
>
> JoinCompiler.getCommonType() has redundant null checks for PDataType that can
> be removed
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
