[
https://issues.apache.org/jira/browse/PHOENIX-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16983928#comment-16983928
]
Hadoop QA commented on PHOENIX-5501:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12986990/PHOENIX-5501.4.x-HBase-1.3-view-ttl.001.patch
against 4.x-HBase-1.3 branch at commit
7e298b3b4b51e5ebfcd46cf0c9724fcf36cbd9fd.
ATTACHMENT ID: 12986990
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+
Bytes.toString(PhoenixDatabaseMetaData.SYSTEM_CATALOG_NAME_BYTES),
minTimestamp), expectedRows, numMatchingRows);
+ private void assertSyscatHaveViewTTLRelatedColumns(String tenantId, String
schemaName, String tableName, String tableType, long ttlValueExpected)
+ String tenantClause = tenantId == null || tenantId.isEmpty() ?
"TENANT_ID IS NULL" : String.format("TENANT_ID = '%s'", tenantId);
+ String sql = String.format(VIEW_TTL_HEADER_SQL, tenantClause,
schemaName, tableName, tableType);
+ final PhoenixTestBuilder.SchemaBuilder schemaBuilder = new
PhoenixTestBuilder.SchemaBuilder(getUrl());
+ // Since the VIEW_TTL property values are not being set, we expect the
view header columns to show up in raw scans only.
+
assertViewHeaderRowsHaveViewTTLRelatedCells(schemaBuilder.getTableOptions().getSchemaName(),
startTime, true, 2);
+ final PhoenixTestBuilder.SchemaBuilder schemaBuilder = new
PhoenixTestBuilder.SchemaBuilder(getUrl());
+
assertEquals(SQLExceptionCode.CANNOT_SET_OR_ALTER_VIEW_TTL_FOR_TABLE_WITH_TTL.getErrorCode(),
e.getErrorCode());
+ final PhoenixTestBuilder.SchemaBuilder schemaBuilder = new
PhoenixTestBuilder.SchemaBuilder(getUrl());
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexReplicationIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3163//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3163//console
This message is automatically generated.
> Add support for VIEW_TTL table property during DDL
> --------------------------------------------------
>
> Key: PHOENIX-5501
> URL: https://issues.apache.org/jira/browse/PHOENIX-5501
> Project: Phoenix
> Issue Type: Sub-task
> Affects Versions: 4.15.0
> Reporter: Jacob Isaac
> Assignee: Jacob Isaac
> Priority: Major
> Attachments: PHOENIX-5501.4.x-HBase-1.3-view-ttl.001.patch
>
>
> We need support VIEW_TTL table property that can be specified during CREATE
> VIEW AND ALTER VIEW commands.
> High level list of tasks
> * Modify SYSCAT to support VIEW TTL related metadata.
> * Add to MetadataProtocol
> * Add to PTable and TableProperty.
> * Modify PhoenixDatabaseMetaData
> * Modify various create table and alter table routines
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
