ChinmaySKulkarni commented on a change in pull request #646: PHOENIX-5597 No
read repair happens when scans filter rows based on a…
URL: https://github.com/apache/phoenix/pull/646#discussion_r351948004
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexCheckerIT.java
##########
@@ -290,27 +290,6 @@ public static void checkUnverifiedCellCount(Connection
conn, String indexTableNa
}
assertEquals(1, cntCellValues);
}
- @Test
- public void testUnverifiedRowIncludesOnlyEmptyCell() throws Exception {
- String dataTableName = generateUniqueName();
- try (Connection conn = DriverManager.getConnection(getUrl())) {
- conn.createStatement().execute("create table " + dataTableName +
- " (id varchar(10) not null primary key, val1 varchar(10),
val2 varchar(10), val3 varchar(10))" + tableDDLOptions);
- String indexTableName = generateUniqueName();
- conn.createStatement().execute("CREATE INDEX " + indexTableName +
" on " +
- dataTableName + " (val1) include (val2, val3)");
- // Configure IndexRegionObserver to fail the last write phase
(i.e., the post index update phase)
- IndexRegionObserver.setFailPostIndexUpdatesForTesting(true);
- conn.createStatement().execute("upsert into " + dataTableName + "
(id, val2) values ('a', 'abcc')");
- conn.commit();
- IndexRegionObserver.setFailPostIndexUpdatesForTesting(false);
- // check that in the first phase we don't send the full row.
- // We count the num of cells for this
- checkUnverifiedCellCount(conn, indexTableName);
Review comment:
As part of reverting PHOENIX-5539, `checkUnverifiedCellCount` method should
also be removed (along with all other imports in the `GlobalIndexCheckerIT`
class) since that method is not used anywhere anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
