gokceni commented on a change in pull request #640: PHOENIX-5578 - CREATE TABLE IF NOT EXISTS loads IndexRegionObserver o… URL: https://github.com/apache/phoenix/pull/640#discussion_r356314599
########## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/CreateIndexCoprocIT.java ########## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.phoenix.end2end.index; + +import org.apache.hadoop.hbase.HColumnDescriptor; +import org.apache.hadoop.hbase.HTableDescriptor; +import org.apache.hadoop.hbase.TableName; +import org.apache.hadoop.hbase.client.Admin; +import org.apache.hadoop.hbase.client.HTable; +import org.apache.hadoop.hbase.util.Bytes; +import org.apache.phoenix.end2end.ParallelStatsDisabledIT; +import org.apache.phoenix.hbase.index.IndexRegionObserver; +import org.apache.phoenix.hbase.index.Indexer; +import org.apache.phoenix.hbase.index.covered.NonTxIndexBuilder; +import org.apache.phoenix.index.GlobalIndexChecker; +import org.apache.phoenix.index.PhoenixIndexCodec; +import org.apache.phoenix.jdbc.PhoenixConnection; +import org.apache.phoenix.query.QueryServices; +import org.apache.phoenix.util.SchemaUtil; +import org.junit.Assert; +import org.junit.Test; + +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.SQLException; +import java.util.HashMap; +import java.util.Map; +import java.util.Properties; + +public class CreateIndexCoprocIT extends ParallelStatsDisabledIT { + private boolean isNamespaceMapped = false; + + @Test + public void testCreateCoprocs() throws Exception { + String schemaName = "S" + generateUniqueName(); + String tableName = "T_" + generateUniqueName(); + String indexName = "I_" + generateUniqueName(); + createBaseTable(schemaName, tableName, true, 0, null); + createIndexTable(schemaName, tableName, indexName); + String physicalTableName = SchemaUtil.getPhysicalHBaseTableName(schemaName, tableName, + isNamespaceMapped).getString(); + String physicalIndexName = SchemaUtil.getPhysicalHBaseTableName(schemaName, + indexName, isNamespaceMapped).getString(); + Admin admin = ((PhoenixConnection) getConnection()).getQueryServices().getAdmin(); + HTableDescriptor baseDescriptor = admin.getTableDescriptor(TableName.valueOf(physicalTableName)); + HTableDescriptor indexDescriptor = admin.getTableDescriptor(TableName.valueOf(physicalIndexName)); + + assertCoprocsContains(IndexRegionObserver.class, baseDescriptor); + assertCoprocsContains(GlobalIndexChecker.class, indexDescriptor); + + removeCoproc(IndexRegionObserver.class, baseDescriptor, admin); + removeCoproc(IndexRegionObserver.class, indexDescriptor, admin); + removeCoproc(GlobalIndexChecker.class, indexDescriptor, admin); + + Map<String, String> props = new HashMap<String, String>(); + props.put(NonTxIndexBuilder.CODEC_CLASS_NAME_KEY, PhoenixIndexCodec.class.getName()); + Indexer.enableIndexing(baseDescriptor, NonTxIndexBuilder.class, + props, 100); + admin.modifyTable(baseDescriptor.getTableName(), baseDescriptor); + baseDescriptor = admin.getTableDescriptor(TableName.valueOf(physicalTableName)); + indexDescriptor = admin.getTableDescriptor(TableName.valueOf(physicalIndexName)); + assertUsingOldCoprocs(baseDescriptor, indexDescriptor); + + createBaseTable(schemaName, tableName, true, 0, null); + baseDescriptor = admin.getTableDescriptor(TableName.valueOf(physicalTableName)); + indexDescriptor = admin.getTableDescriptor(TableName.valueOf(physicalIndexName)); + assertUsingOldCoprocs(baseDescriptor, indexDescriptor); + + } + + @Test + public void testCreateOnExistingHBaseTable() throws Exception { + String schemaName = generateUniqueName(); + String tableName = generateUniqueName(); + String indexName = generateUniqueName(); + byte[] cf = Bytes.toBytes("f"); + try (PhoenixConnection conn = getConnection()){ + TableName table = TableName.valueOf(SchemaUtil.getPhysicalHBaseTableName(schemaName, + tableName, isNamespaceMapped).getString()); + HTableDescriptor originalDesc = new HTableDescriptor(table); + originalDesc.addFamily(new HColumnDescriptor(cf)); + Admin admin = conn.getQueryServices().getAdmin(); + admin.createTable(originalDesc); + createBaseTable(schemaName, tableName, true, 0, null); + HTableDescriptor baseDescriptor = admin.getTableDescriptor(table); + assertUsingNewCoprocs(baseDescriptor); + createIndexTable(schemaName, tableName, indexName); + baseDescriptor = admin.getTableDescriptor(table); + TableName indexTable = TableName.valueOf(SchemaUtil.getPhysicalHBaseTableName(schemaName, + indexName, isNamespaceMapped).getString()); + HTableDescriptor indexDescriptor = admin.getTableDescriptor(indexTable); + assertUsingNewCoprocs(baseDescriptor, indexDescriptor); + } + } + + private void assertUsingOldCoprocs(HTableDescriptor baseDescriptor, + HTableDescriptor indexDescriptor) { + assertCoprocsContains(Indexer.class, baseDescriptor); + assertCoprocsNotContains(IndexRegionObserver.class, baseDescriptor); + assertCoprocsNotContains(IndexRegionObserver.class, indexDescriptor); + assertCoprocsNotContains(GlobalIndexChecker.class, indexDescriptor); + } + + private void assertUsingNewCoprocs(HTableDescriptor baseDescriptor) { + assertCoprocsContains(IndexRegionObserver.class, baseDescriptor); + assertCoprocsNotContains(Indexer.class, baseDescriptor); + } + + private void assertUsingNewCoprocs(HTableDescriptor baseDescriptor, + HTableDescriptor indexDescriptor) { + assertCoprocsContains(IndexRegionObserver.class, baseDescriptor); + assertCoprocsNotContains(Indexer.class, baseDescriptor); + assertCoprocsNotContains(Indexer.class, indexDescriptor); + assertCoprocsContains(GlobalIndexChecker.class, indexDescriptor); + } + + private void assertCoprocsContains(Class clazz, HTableDescriptor descriptor) { + String expectedCoprocName = clazz.getName(); + boolean foundCoproc = isCoprocPresent(descriptor, expectedCoprocName); + Assert.assertTrue("Could not find coproc " + expectedCoprocName + + " in descriptor " + descriptor,foundCoproc); + } + + private void assertCoprocsNotContains(Class clazz, HTableDescriptor descriptor) { + String expectedCoprocName = clazz.getName(); + boolean foundCoproc = isCoprocPresent(descriptor, expectedCoprocName); + Assert.assertFalse("Could find coproc " + expectedCoprocName + + " in descriptor " + descriptor,foundCoproc); + } + + private boolean isCoprocPresent(HTableDescriptor descriptor, String expectedCoprocName) { + boolean foundCoproc = false; + for (String coprocName : descriptor.getCoprocessors()){ + if (coprocName.equals(expectedCoprocName)){ + foundCoproc = true; + break; + } + } + return foundCoproc; + } + + private void removeCoproc(Class clazz, HTableDescriptor descriptor, Admin admin) throws Exception { + descriptor.removeCoprocessor(clazz.getName()); + admin.modifyTable(descriptor.getTableName(), descriptor); + } + + private void createIndexTable(String schemaName, String tableName, String indexName) + throws SQLException { + Connection conn = getConnection(); + String fullTableName = SchemaUtil.getTableName(schemaName, tableName); + conn.createStatement().execute("CREATE INDEX " + indexName + " ON " + fullTableName + "(v1)"); + } + + private void createBaseTable(String schemaName, String tableName, boolean multiTenant, Integer saltBuckets, String splits) + throws SQLException { + Connection conn = getConnection(); + if (isNamespaceMapped) { Review comment: @gjacoby126 I am wondering about this variable. Other than this, LGTM. But why do we have this if we don't set it? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
