[
https://issues.apache.org/jira/browse/PHOENIX-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995899#comment-16995899
]
Hadoop QA commented on PHOENIX-5618:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12988819/PHOENIX-5618.master.001.patch
against master branch at commit e7207b96402852440243a0d7d8c7c572cffcd322.
ATTACHMENT ID: 12988819
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ String dataTableDDL = "CREATE TABLE %s (ID INTEGER NOT NULL
PRIMARY KEY, NAME VARCHAR, VB VARBINARY)";
+ conn.createStatement().execute(String.format(indexTableDDL,
indexTableName, dataTableName));
+ PreparedStatement upsertDataStmt =
conn.prepareStatement(String.format(upsertData, dataTableName));
+ PreparedStatement upsertIndexStmt =
conn.prepareStatement(String.format(upsertIndex, indexTableName));
+ private void upsertRow(PreparedStatement stmt, int id, String name, byte[]
val) throws SQLException {
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3189//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3189//console
This message is automatically generated.
> IndexScrutinyTool marks rows with VARBINARY or array type columns as invalid
> ----------------------------------------------------------------------------
>
> Key: PHOENIX-5618
> URL: https://issues.apache.org/jira/browse/PHOENIX-5618
> Project: Phoenix
> Issue Type: Bug
> Reporter: Gokcen Iskender
> Assignee: Gokcen Iskender
> Priority: Major
> Attachments: PHOENIX-5618.master.001.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> IndexScrutinyMapper has a compare method which uses equals to compare array
> types.
> Even though arrays are same, it returns false. It should use Arrays.equals to
> compare such types
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
