[
https://issues.apache.org/jira/browse/PHOENIX-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17001195#comment-17001195
]
Hudson commented on PHOENIX-5641:
---------------------------------
FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3212 (See
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/3212/])
PHOENIX-5641 Decouple phoenix-queryserver from phoenix-core (stoty: rev
78cfb911a157fa74fd9868099e20df3eae6f62ba)
* (delete) bin/queryserver.py
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/query/QueryServices.java
* (delete) bin/sqlline-thin.py
> Decouple phoenix-queryserver from phoenix-core
> ----------------------------------------------
>
> Key: PHOENIX-5641
> URL: https://issues.apache.org/jira/browse/PHOENIX-5641
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.1.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
> Fix For: 5.1.0
>
> Attachments: PHOENIX-5641.master.v1.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> phoenix-queryserver has been moved to a separate repo, and it's versioning
> has been decoupled from that of phoenix-core.
> Yet, phoenix-queryserver still uses code from phoenix-core, and phoenix-core
> in turn contains code that is only used by phoenix-queryserver.
> This causes (at least) the following problems:
> * Adding new features to PQS is problematic, because it depends on an old
> released version of phoenix
> * The phoenix-thin-client includes phoenix code, that is not really necessary
> I propose fully decoupling the PQS code from phoenix proper. This effectively
> means:
> * duplicating the PQS specific configuration parameter names and defaults in
> PQS
> * copying a minimal amount of code for building the JDBC connection URL
> * copying the InstanceResolver cache class
> The tests are still dependent on phoenix-core, but I do not consider that a
> problem.
> If/when this patch lands in PQS, we should also remove the PQS specific
> parameters from phoenix-core.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
