kadirozde commented on a change in pull request #660: PHOENIX-5644:
IndexUpgradeTool should sleep only once if there is at …
URL: https://github.com/apache/phoenix/pull/660#discussion_r360582397
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java
##########
@@ -367,6 +358,53 @@ private int executeTool(Connection conn,
ConnectionQueryServices queryServices,
return 0;
}
+ private void executeToolForImmutableTables(ConnectionQueryServices
queryServices,
Review comment:
I suggest having a separate list, i.e., mutableList, for mutable tables. We
should disable and modify immutable tables first and then record the current
time, say as startWaitTime. Then we can upgrade mutable tables (disable, modify
and rebuildIndexes). After that we can sleep for 11 minutes - (current time -
startWaitTime) and call rebuildIndexes for mutable tables. This eliminates
unnecessary sleep time better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
