[
https://issues.apache.org/jira/browse/PHOENIX-5096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17002435#comment-17002435
]
Hadoop QA commented on PHOENIX-5096:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12989387/5096-4.x-HBase-1.5-v2.txt
against 4.x-HBase-1.5 branch at commit
25cc0764bc7c69511df61e777f851b963f4798fb.
ATTACHMENT ID: 12989387
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ if (dataPlan != null &&
dataPlan.getTableRef().getTable().getType() != PTableType.INDEX) { // Sanity
check
+ // we can skip a region completely for local indexes
if the data plan does not intersect
+ if
(!dataScanRanges.intersectRegion(regionInfo.getStartKey(),
regionInfo.getEndKey(), false)) {
+ assertEquals("IDX",
plan.getContext().getCurrentTable().getTable().getName().getString());
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3216//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3216//console
This message is automatically generated.
> Local index region pruning is not working as expected.
> ------------------------------------------------------
>
> Key: PHOENIX-5096
> URL: https://issues.apache.org/jira/browse/PHOENIX-5096
> Project: Phoenix
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Priority: Major
> Attachments: 5096-4.x-HBase-1.5-v2.txt, 5096-4.x-HBase-1.5.txt
>
>
> The pruning of local indexes should do the following:
> * Use the local index
> * Reduce the number of regions based on filters on the table's primary key
> (i.e. WHERE conditions including prefixes of the primary key)
> Instead it looks like in order for this to work the needed PK column need to
> be included in the local index itself, changing the sort order of the local
> index.
> I'll provide some examples in the comments.
> [~giacomotaylor], [~tdsilva], [~vincentpoon], [~elserj], [~gjacoby]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
