[
https://issues.apache.org/jira/browse/PHOENIX-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004332#comment-17004332
]
Hadoop QA commented on PHOENIX-5652:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12989557/PHOENIX-5652.4.x-HBase-1.4.001.patch
against 4.x-HBase-1.4 branch at commit
356f4cd7d43bccb9538a5a2b94863b1c52cd9aad.
ATTACHMENT ID: 12989557
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ protected static String[] getArgValues(String schemaName, String
dataTable, String indxTable, Long batchSize,
+ {"CREATE TABLE %s (ID INTEGER NOT NULL PRIMARY KEY, NAME
VARCHAR, ZIP INTEGER, EMPLOY_DATE TIMESTAMP, EMPLOYER VARCHAR)",
+ ,{ "CREATE TABLE %s (ID INTEGER NOT NULL PRIMARY KEY, NAME
VARCHAR, ZIP INTEGER, EMPLOY_DATE TIMESTAMP, EMPLOYER VARCHAR) SALT_BUCKETS=2",
+ try (Connection conn = DriverManager.getConnection(getUrl(),
PropertiesUtil.deepCopy(TEST_PROPERTIES))) {
+ assertEquals("[name-3, " + new Timestamp(testTime).toString() + ", 3,
95123]\tTarget row not found",
+ private static String[] getArgValues(String schemaName, String dataTable,
String indxTable, Long batchSize,
+ private static List<Job> runScrutiny(String schemaName, String
dataTableName, String indexTableName)
+ private static List<Job> runScrutiny(String schemaName, String
dataTableName, String indexTableName,
+ public static List<Job> runScrutiny(String schemaName, String
dataTableName, String indexTableName,
+ "CREATE TABLE %s (ID INTEGER NOT NULL PRIMARY KEY, NAME
VARCHAR, ZIP INTEGER, EMPLOY_DATE TIMESTAMP, EMPLOYER VARCHAR)",
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexScrutinyToolIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3219//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3219//console
This message is automatically generated.
> IndexScrutinyTool perf improvement to query indexes using skipscanfilter
> ------------------------------------------------------------------------
>
> Key: PHOENIX-5652
> URL: https://issues.apache.org/jira/browse/PHOENIX-5652
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Gokcen Iskender
> Assignee: Gokcen Iskender
> Priority: Major
> Attachments: PHOENIX-5652.4.x-HBase-1.4.001.patch,
> PHOENIX-5652.master.001.patch, PHOENIX-5652.master.002.patch
>
>
> When the IndexScrutinyTool uses DATA_TABLE as source (source type DATA_TABLE
> or BOTH), it constructs a query that uses a WHERE IN statement to look up the
> data table entries in the index table.
> Consider a table with ID Integer PK, NAME varchar and index with PK NAME
> The current query is constructed like this:
> IndexTable WHERE (:ID, 0:NAME) IN ()
> The WhereOptimizer looks at the column order to decide whether to use
> SkipScanFilter or not. The PK of the index table should come before the PK of
> data table.
> If the query is written like this:
> IndexTable WHERE (0:NAME, :ID) IN () then SkipScanFilter is used and the
> query is much faster.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
