[ 
https://issues.apache.org/jira/browse/PHOENIX-5655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17007022#comment-17007022
 ] 

Chinmay Kulkarni commented on PHOENIX-5655:
-------------------------------------------

[~vjasani] +1 to the actual change. Some nits for both the tests:

* Let's move the connection creation just before the statement creation and 
result set creation and put them in one try-with-resources block so they are 
auto-closed.
* You don't need to catch(Throwable) and then _fail_ inside of that block, 
instead just let the throwable get bubbled up and fail the test.


> ServerCache using table map is not correctly removed
> ----------------------------------------------------
>
>                 Key: PHOENIX-5655
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5655
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 5.1.0
>            Reporter: Viraj Jasani
>            Assignee: Viraj Jasani
>            Priority: Major
>             Fix For: 5.1.0, 4.15.1
>
>         Attachments: PHOENIX-5655.master.000.patch
>
>
> ServerCacheClient should remove cacheId -> PTable map entry while removing 
> cached table from all RegionServers, which is not happening correctly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to