[ 
https://issues.apache.org/jira/browse/PHOENIX-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17008455#comment-17008455
 ] 

Lars Hofhansl commented on PHOENIX-5659:
----------------------------------------

Looks good to me. No need to file a PR.

Could you add a little test that exhausts the resultset using next() and make 
sure the statement is closed as well?

 

> Support Statement#closeOnCompletion()
> -------------------------------------
>
>                 Key: PHOENIX-5659
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5659
>             Project: Phoenix
>          Issue Type: Task
>            Reporter: Iwao AVE!
>            Priority: Major
>         Attachments: PHOENIX-5659-master.patch
>
>
> I am a member of [MyBatis|https://github.com/mybatis] team and a user 
> [reported|https://github.com/mybatis/mybatis-3/issues/1351#issuecomment-569619849]
>  that Phoenix does not support java.sql.Statement#closeOnCompletion() yet.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to