ChinmaySKulkarni commented on a change in pull request #671: PHOENIX-4845 
Support using Row Value Constructors in OFFSET clause fo…
URL: https://github.com/apache/phoenix/pull/671#discussion_r363575916
 
 

 ##########
 File path: 
phoenix-core/src/main/java/org/apache/phoenix/compile/WhereCompiler.java
 ##########
 @@ -154,14 +156,18 @@ public static Expression compile(StatementContext 
context, FilterableStatement s
         }
         
         if (context.getCurrentTable().getTable().getType() != 
PTableType.PROJECTED && context.getCurrentTable().getTable().getType() != 
PTableType.SUBQUERY) {
-            expression = WhereOptimizer.pushKeyExpressionsToScan(context, 
statement, expression, extractedNodes);
+            Set<HintNode.Hint> hints = null;
+            if(statement.getHint() != null){
+                hints = statement.getHint().getHints();
+            }
+            expression = WhereOptimizer.pushKeyExpressionsToScan(context, 
hints, expression, extractedNodes, minOffset);
         }
         setScanFilter(context, statement, expression, 
whereCompiler.disambiguateWithFamily);
 
         return expression;
     }
     
-    private static class WhereExpressionCompiler extends ExpressionCompiler {
+    public static class WhereExpressionCompiler extends ExpressionCompiler {
 
 Review comment:
   Just checking if this intended or accidental..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to