[
https://issues.apache.org/jira/browse/PHOENIX-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17009625#comment-17009625
]
Hadoop QA commented on PHOENIX-5658:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12990079/PHOENIX-5658.master.001.patch
against master branch at commit 7bcc9bc89bbe86eedbf8223d101dadb3cf57cc4c.
ATTACHMENT ID: 12990079
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ "CREATE INDEX %s ON %s (NAME) INCLUDE (ZIP)
ASYNC ", indexTableName, dataTableFullName);
+ // lead to any change on index and thus the index verify during
index rebuild should fail
+ IndexTool indexTool = runIndexTool(directApi, useSnapshot,
schemaName, dataTableName, indexTableName, null, -1, new String[0]);
+ public static final String
NUM_CONCURRENT_INDEX_VERIFY_THREADS_CONF_KEY = "index.verify.threads.max";
+ public static final String INDEX_VERIFY_ROW_COUNTS_PER_TASK_CONF_KEY =
"index.verify.threads.max";
+ indexHTable =
ServerUtil.ConnectionFactory.getConnection(ServerUtil.ConnectionType.INDEX_WRITER_CONNECTION,
+ new ThreadPoolBuilder("IndexVerify",
env.getConfiguration()).setMaxThread(NUM_CONCURRENT_INDEX_VERIFY_THREADS_CONF_KEY,
+ public ImmutableBytesWritable getLatestValue(ColumnReference ref,
long ts) throws IOException {
+ byte[] builtIndexRowKey = indexMaintainer.buildRowKey(valueGetter,
new ImmutableBytesWritable(dataRow.getRow()),
+ Put indexPut = indexMaintainer.buildUpdateMutation(kvBuilder,
valueGetter, new ImmutableBytesWritable(dataRow.getRow()), ts, null, null);
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3242//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3242//console
This message is automatically generated.
> IndexTool to verify index rows inline
> -------------------------------------
>
> Key: PHOENIX-5658
> URL: https://issues.apache.org/jira/browse/PHOENIX-5658
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.14.3
> Reporter: Kadir OZDEMIR
> Assignee: Kadir OZDEMIR
> Priority: Major
> Attachments: PHOENIX-5658.master.001.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It is important to make sure that index rows are rebuilt correctly by
> IndexTool. IndexScrutinyTool is very valuable to do this but when compared to
> IndexTool it runs 5-10 times slower. It is almost impractical to run
> IndexScrutinyTool to verify large index tables as it can take hours and
> sometimes days to do that. IndexTool runs faster since it rebuilds an index
> table on the server side and this eliminates back and forth data transfer
> between clients and servers. Thus, having an option to verify index rows
> inline as part of IndexTool would eliminate the need to run IndexScrutinyTool
> mostly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
