kadirozde commented on a change in pull request #672: PHOENIX-5658 IndexTool to
verify index rows inline
URL: https://github.com/apache/phoenix/pull/672#discussion_r363936980
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java
##########
@@ -334,7 +334,7 @@
public static final long
DEFAULT_GLOBAL_INDEX_ROW_AGE_THRESHOLD_TO_DELETE_MS = 7*24*60*60*1000; /* 7
days */
public static final boolean DEFAULT_INDEX_REGION_OBSERVER_ENABLED = true;
- public static final long DEFAULT_INDEX_REBUILD_PAGE_SIZE_IN_ROWS = 16*1024;
+ public static final long DEFAULT_INDEX_REBUILD_PAGE_SIZE_IN_ROWS = 32*1024;
Review comment:
The increase is to have more rows for each skip scan to reduce the overall
overhead of scan operations. The rebuild page size is the number of rows to be
rebuilt at a time per data table region. Immediately after these rows are
rebuilt on the server side, a number of scan threads start verifying them using
skip scans again on the server side. Having more rows to be rebuilt at a time
increases the number of rows per skip scan. This makes skip scan more effective.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
