swaroopak commented on a change in pull request #662: PHOENIX-5645 -
GlobalIndexChecker should prevent compaction from purg…
URL: https://github.com/apache/phoenix/pull/662#discussion_r363980979
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexCheckerIT.java
##########
@@ -385,21 +402,36 @@ public void testOnePhaseOverwrite() throws Exception {
}
}
+ private void createTableAndIndexes(Connection conn, String dataTableName,
+ String indexTableName) throws Exception
{
+ populateTable(dataTableName); // with two rows ('a', 'ab', 'abc',
'abcd') and ('b', 'bc', 'bcd', 'bcde')
+ conn.createStatement().execute("CREATE INDEX " + indexTableName + "1
on " +
+ dataTableName + " (val1) include (val2, val3)" + (async ?
"ASYNC" : ""));
+ conn.createStatement().execute("CREATE INDEX " + indexTableName + "2
on " +
+ dataTableName + " (val2) include (val1, val3)" + (async ?
"ASYNC" : ""));
+ conn.commit();
+ if (async) {
+ // run the index MR job.
+ IndexToolIT.runIndexTool(true, false, null, dataTableName,
indexTableName + "1");
+ IndexToolIT.runIndexTool(true, false, null, dataTableName,
indexTableName + "2");
+ }
+ }
+
+ private void assertTableHasTtl(Connection conn, TableName tableName, int
ttl)
+ throws Exception{
Review comment:
nit: space begore '{'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
