gjacoby126 commented on a change in pull request #662: PHOENIX-5645 - GlobalIndexChecker should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/662#discussion_r365623815
########## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/MaxLookbackIT.java ########## @@ -0,0 +1,351 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.phoenix.end2end; + + +import com.google.common.collect.Maps; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.TableName; +import org.apache.hadoop.hbase.client.Admin; +import org.apache.hadoop.hbase.protobuf.generated.AdminProtos; +import org.apache.hadoop.hbase.regionserver.HRegion; +import org.apache.hadoop.hbase.regionserver.ScanInfoUtil; +import org.apache.hadoop.hbase.util.Bytes; +import org.apache.hadoop.hbase.util.EnvironmentEdgeManager; +import org.apache.phoenix.exception.SQLExceptionCode; +import org.apache.phoenix.query.QueryServices; +import org.apache.phoenix.util.PhoenixRuntime; +import org.apache.phoenix.util.QueryUtil; +import org.apache.phoenix.util.ReadOnlyProps; +import org.apache.phoenix.util.TestUtil; +import org.junit.Assert; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Test; + +import java.io.IOException; +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.ResultSet; +import java.sql.SQLException; +import java.sql.Statement; +import java.util.Map; +import java.util.Properties; + +import static org.apache.phoenix.util.TestUtil.assertRawCellCount; +import static org.apache.phoenix.util.TestUtil.assertRawRowCount; +import static org.apache.phoenix.util.TestUtil.assertRowExistsAtSCN; +import static org.apache.phoenix.util.TestUtil.assertRowHasExpectedValueAtSCN; +import static org.apache.phoenix.util.TestUtil.assertTableHasTtl; +import static org.apache.phoenix.util.TestUtil.assertTableHasVersions; + +@NeedsOwnMiniClusterTest +public class MaxLookbackIT extends BaseUniqueNamesOwnClusterIT { + private static final Log LOG = LogFactory.getLog(MaxLookbackIT.class); + private static final int MAX_LOOKBACK_AGE = 10; + private static final int ROWS_POPULATED = 2; + private String tableDDLOptions; + private StringBuilder optionBuilder; + + @BeforeClass + public static synchronized void doSetup() throws Exception { + Map<String, String> props = Maps.newHashMapWithExpectedSize(1); + props.put(QueryServices.GLOBAL_INDEX_ROW_AGE_THRESHOLD_TO_DELETE_MS_ATTRIB, Long.toString(0)); + props.put(ScanInfoUtil.PHOENIX_MAX_LOOKBACK_AGE_CONF_KEY, Integer.toString(MAX_LOOKBACK_AGE)); + setUpTestDriver(new ReadOnlyProps(props.entrySet().iterator())); + } + + @Before + public void beforeTest(){ + optionBuilder = new StringBuilder(); + this.tableDDLOptions = optionBuilder.toString(); + } + + @Test + public void testTooLowSCNWithMaxLookbackAge() throws Exception { + try (Connection conn = DriverManager.getConnection(getUrl())) { + String dataTableName = generateUniqueName(); + String indexStem = generateUniqueName(); + createTableAndIndexes(conn, dataTableName, indexStem); + //need to sleep long enough for the SCN to still find the syscat row for the table + Thread.sleep(MAX_LOOKBACK_AGE * 1000 + 1000); + Properties props = new Properties(); + props.setProperty(PhoenixRuntime.CURRENT_SCN_ATTRIB, + Long.toString(EnvironmentEdgeManager.currentTime() - (MAX_LOOKBACK_AGE + 1) * 1000)); + try (Connection connscn = DriverManager.getConnection(getUrl(), props)) { + connscn.createStatement().executeQuery("select * from " + dataTableName); + } catch (SQLException se) { + SQLExceptionCode code = + SQLExceptionCode.CANNOT_QUERY_TABLE_WITH_SCN_OLDER_THAN_MAX_LOOKBACK_AGE; + TestUtil.assertSqlExceptionCode(code, se); + return; + } + } + Assert.fail("We should have thrown an exception for the too-early SCN"); + } + + @Test(timeout=120000L) + public void testRecentlyDeletedRowsNotCompactedAway() throws Exception { + try (Connection conn = DriverManager.getConnection(getUrl())) { + String dataTableName = generateUniqueName(); + String indexStem = generateUniqueName(); + createTableAndIndexes(conn, dataTableName, indexStem); Review comment: Unfortunately the tables are slightly different each time. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
