[
https://issues.apache.org/jira/browse/PHOENIX-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17015540#comment-17015540
]
Hadoop QA commented on PHOENIX-5634:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12990922/PHOENIX-5634.4.x-HBase-1.3.v1.patch
against 4.x-HBase-1.3 branch at commit
6405839b60c410292c0e2c8cbbdee55d09343bab.
ATTACHMENT ID: 12990922
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.StatsEnabledSplitSystemCatalogIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TenantSpecificViewIndexSaltedIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.MaxLookbackIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3297//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3297//console
This message is automatically generated.
> Use 'phoenix.default.update.cache.frequency' from connection properties at
> query time
> -------------------------------------------------------------------------------------
>
> Key: PHOENIX-5634
> URL: https://issues.apache.org/jira/browse/PHOENIX-5634
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 4.15.0, 5.1.0
> Reporter: Nitesh Maheshwari
> Assignee: Nitesh Maheshwari
> Priority: Minor
> Fix For: 5.1.0, 4.15.1
>
> Attachments: PHOENIX-5634.4.x-HBase-1.3.v1.patch,
> PHOENIX-5634.master.v1.patch
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> We have the config 'phoenix.default.update.cache.frequency' which specifies
> the time a client should wait before it refreshes its metadata cache entry
> for a table by fetching the latest metadata from system catalog. This value
> could be set for a table in the following ways (in the following preference
> order):
> # Specifying UPDATE_CACHE_FREQUENCY in table creation DDL
> # Specifying the connection property 'phoenix.default.update.cache.frequency'
> # Using the default 'phoenix.default.update.cache.frequency'
> At query time, we look at whether UPDATE_CACHE_FREQUENCY was specified for
> the table and decide based on that value if the latest metadata for a table
> should be fetched from system catalog to update the cache. However, when the
> table doesn't have UPDATE_CACHE_FREQUENCY specified we should look at the
> connection property 'phoenix.default.update.cache.frequency' (or the default
> 'phoenix.default.update.cache.frequency' when the connection level property
> is not set) to make that decision. The support for latter is missing - this
> Jira is intended to add that.
> This will aid exiting installations where the tables were created without a
> specified UPDATE_CACHE_FREQUENCY, and thus always hit the system catalog to
> get the latest metadata when referenced. With this support, we will be able
> to reduce the load on system catalog by specifying a connection level
> property for all tables referenced from the connection (as against UPSERTing
> each table entry in system catalog to set an UPDATE_CACHE_FREQUENCY value).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
