gjacoby126 commented on a change in pull request #683: PHOENIX-5674 IndexTool 
to not write already correct index rows/CFs
URL: https://github.com/apache/phoenix/pull/683#discussion_r366675047
 
 

 ##########
 File path: 
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java
 ##########
 @@ -205,11 +205,12 @@ public static IndexVerifyType fromValue(byte[] value) {
             "This parameter is deprecated. Direct mode will be used whether it 
is set or not. Keeping it for backwards compatibility.");
 
     private static final Option VERIFY_OPTION = new Option("v", "verify", true,
-            "To verify every data row has a corresponding row. The accepted 
values are NONE, ONLY, BEFORE," +
-                    " AFTER, and BOTH. NONE is for no inline verification, 
which is also the default for this option. " +
-                    "ONLY is for verifying without rebuilding index rows. The 
rest for verifying before, after, and " +
-                    "both before and after rebuilding row. If the verification 
is done before rebuilding rows and " +
-                    "the correct index rows are not rebuilt. Currently 
supported values are NONE, ONLY and AFTER ");
+            "To verify every data row has a corresponding row of a global 
index. For other types of indexes, " +
+                    "this option will be silently ignored. The accepted values 
are NONE, ONLY, BEFORE,  AFTER, and BOTH. " +
+                    "NONE is for no inline verification, which is also the 
default for this option. ONLY is for " +
+                    "verifying without rebuilding index rows. The rest for 
verifying before, after, and both before " +
+                    "and after rebuilding row. If the verification is done 
before rebuilding rows and the correct " +
 
 Review comment:
   nit: "then the correct index rows will not be rebuilt"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to