kadirozde commented on a change in pull request #685: PHOENIX-5676
Inline-verification from IndexTool does not handle TTL/r…
URL: https://github.com/apache/phoenix/pull/685#discussion_r366688528
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java
##########
@@ -584,16 +633,19 @@ public boolean next(List<Cell> results) throws
IOException {
if (onlyVerify) {
addToBeVerifiedIndexRows();
}
- ArrayList<KeyRange> keys = new ArrayList<>(rowCountPerTask);
+ ArrayList<KeyRange> keyRanges = new ArrayList<>(rowCountPerTask);
+ Set<byte[]> indexRowKeys = new HashSet<>(rowCountPerTask);
Review comment:
A byte array hash set would not work here. The byte array needs to be
wrapped with equals and hashCode, or Map<byte[], Put> created with
Maps.newTreeMap(Bytes.BYTES_COMPARATOR) can be used instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
