kadirozde commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs URL: https://github.com/apache/phoenix/pull/683#discussion_r366696867
########## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java ########## @@ -385,13 +388,13 @@ private void verifySingleIndexRow(Result indexRow, final Put dataRow) throws IOE // This means the index row does not have any covered columns. We just need to check if the index row // has only one cell (which is the empty column cell) if (indexRow.rawCells().length == 1) { - return; + return false; Review comment: Yes, this is a success path and it should be true. Good catch. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services