[
https://issues.apache.org/jira/browse/PHOENIX-5676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17015879#comment-17015879
]
Hadoop QA commented on PHOENIX-5676:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12990960/PHOENIX-5676-4.x-HBase-1.5.patch
against 4.x-HBase-1.5 branch at commit
beb6457086c8e51fc8be5eceb468a1edf8a358b7.
ATTACHMENT ID: 12990960
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ + " (ID INTEGER NOT NULL PRIMARY KEY, NAME VARCHAR,
CODE VARCHAR) COLUMN_ENCODED_BYTES=0");
+ indexTableTTL =
indexHTable.getTableDescriptor().getColumnFamilies()[0].getTimeToLive();
+ logToIndexToolOutputTable(dataRow.getRow(), indexRow.getRow(), ts,
getMaxTimestamp(Arrays.asList(indexRow.rawCells())), errorMsg);
+ logToIndexToolOutputTable(dataRow.getRow(),
indexRow.getRow(), ts, getMaxTimestamp(Arrays.asList(indexRow.rawCells())),
errorMsg);
+ logToIndexToolOutputTable(dataRow.getRow(),
indexRow.getRow(), ts, getMaxTimestamp(Arrays.asList(indexRow.rawCells())),
+ logToIndexToolOutputTable(dataRow.getRow(), indexRow.getRow(), ts,
getMaxTimestamp(Arrays.asList(indexRow.rawCells())), errorMsg);
+ * @param indexRowKeys The set of rowKeys this task is dealing with. Not
supposed to be shared with any other
+ private void verifyIndexRows(ArrayList<KeyRange> keyRanges, Set<byte[]>
indexRowKeys) throws IOException {
+ logToIndexToolOutputTable(null, result.getRow(), 0,
getMaxTimestamp(Arrays.asList(result.rawCells())), errorMsg);
+ if (indexTableTTL != HConstants.FOREVER && ts < (currentTime -
(long)indexTableTTL * 1000)) {
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3307//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3307//console
This message is automatically generated.
> Inline-verification from IndexTool does not handle TTL/row-expiry
> -----------------------------------------------------------------
>
> Key: PHOENIX-5676
> URL: https://issues.apache.org/jira/browse/PHOENIX-5676
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.15.1, 4.14.3
> Reporter: Priyank Porwal
> Assignee: Abhishek Singh Chouhan
> Priority: Major
> Fix For: 5.1.0, 4.15.1, 4.16.0
>
> Attachments: PHOENIX-5676-4.x-HBase-1.5.patch,
> PHOENIX-5676-4.x-HBase-1.5.patch, PHOENIX-5676-master.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> If a data-table has TTL on it, it's indexes inherit the TTL too. Hence when
> we run IndexTool with verification on such tables and it's indexes, rows that
> are near expiry will successfully get rebuilt, but may not be returned on
> verification read due to expiry. This will result in index verification
> problem and may also fail rebuild job.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
