[ 
https://issues.apache.org/jira/browse/PHOENIX-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016242#comment-17016242
 ] 

Xinyi Yan commented on PHOENIX-5678:
------------------------------------

+1 lgtm

> Cleanup anonymous inner classes used for BaseMutationPlan
> ---------------------------------------------------------
>
>                 Key: PHOENIX-5678
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5678
>             Project: Phoenix
>          Issue Type: Sub-task
>    Affects Versions: 5.1.0, 4.15.1
>            Reporter: Viraj Jasani
>            Assignee: Viraj Jasani
>            Priority: Major
>             Fix For: 5.1.0, 4.15.1
>
>         Attachments: PHOENIX-5678.master.000.patch
>
>
> BaseMutationPlan has been extended as anonymous inner class at multiple 
> places and some of them have lots of logic placed in overridden methods. We 
> should convert them to Inner classes and use object of extended inner class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to