gjacoby126 commented on a change in pull request #692: PHOENIX-5689: 
TableNotFoundException in IndexUpgradeTool in case of v…
URL: https://github.com/apache/phoenix/pull/692#discussion_r372084654
 
 

 ##########
 File path: 
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java
 ##########
 @@ -652,51 +652,15 @@ private int startIndexRebuilds(Connection conn,
                     (GLOBAL_INDEX_ID.equals(tenantId)?"":"_"+tenantId) +"_"
                     + UUID.randomUUID().toString();
             String[] args = getIndexToolArgValues(schema, baseTable, 
indexName, outFile, tenantId);
-            Connection newConnection = conn;
-            Connection tenantConnection = null;
             try {
                 LOGGER.info("Rebuilding index: " + StringUtils.join( 
args,","));
                 if (!dryRun) {
-                    // If the index is in DISABLED state, indexTool will fail.
-                    // First to ALTER REBUILD ASYNC.
 
 Review comment:
   this is now taken care of within the index tool? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to