siddhimehta commented on a change in pull request #616: PHOENIX-5432: Refactor
LiteralExpression to use the builder pattern
URL: https://github.com/apache/phoenix/pull/616#discussion_r372689575
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/CountAggregateFunction.java
##########
@@ -46,10 +47,12 @@
@BuiltInFunction(name=CountAggregateFunction.NAME, args= {@Argument()} )
public class CountAggregateFunction extends SingleAggregateFunction {
public static final String NAME = "COUNT";
- public static final List<Expression> STAR =
Arrays.<Expression>asList(LiteralExpression.newConstant(1, Determinism.ALWAYS));
+// STAR is never used so I commented it out
+// public static final List<Expression> STAR =
Arrays.<Expression>asList(new
LiteralExpression.Builder().setValue(1).setDeterminism(Determinism.ALWAYS).build());
Review comment:
unused code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
