tkhurana commented on a change in pull request #697: PHOENIX-5706 IndexTool
verification reports failure when data row has…
URL: https://github.com/apache/phoenix/pull/697#discussion_r373704536
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java
##########
@@ -682,9 +682,8 @@ private boolean verifySingleIndexRow(Result indexRow,
final Put dataRow) throws
Put indexPut =
indexMaintainer.buildUpdateMutation(GenericKeyValueBuilder.INSTANCE,
valueGetter, new ImmutableBytesWritable(dataRow.getRow()), ts,
null, null);
if (indexPut == null) {
- String errorMsg = "Empty index update";
- logToIndexToolOutputTable(dataRow.getRow(), indexRow.getRow(), ts,
getMaxTimestamp(indexRow), errorMsg);
- return false;
+ // This means the dat row does not have any covered column values
Review comment:
Nit: the comment should be `data row`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
